Dart format#123
Merged
Merged
Conversation
formats all dart files using `dart format .` from the root project dir this makes the code style repeatable by new contributors and makes PR review easier
checks code has been formatted with dart format on push and pull request adds a note in README for contributors
fixes two analyzer errors for return blocks on new lines from if blocks
needs to use flutter pub get not dart pub get
Closed
reduce time to complete and stop running twice for pull requests
no need to setup the env twice the exact same way as they don't conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This formats the project and adds a workflow to check that each contribution has also been formatted.
plus small fix to get rid of analyzer errors which could be changed to warnings but that's another day.