Added disconnection handling, and fixed state changing of navigation on connection.#111
Merged
Conversation
zjs81
previously requested changes
Jan 29, 2026
to call _handleDisconnection when it fails update. Updated ScannerScreen to manage navigation state logic on connection.
d4bf4ce to
34a6b5d
Compare
Owner
|
@cursor review |
added 2 commits
January 28, 2026 21:29
- Fix memory leak by adding dispose() to remove connection listener - Fix typo: changedNavgation -> _changedNavigation - Add mounted check before navigation to prevent errors - Remove overly aggressive _handleDisconnection() call on battery request failure - Only reset battery flag on error to allow retry without disconnecting
This was the author's original intent - use battery request failure as a signal that the connection is lost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added error catching to requestBatteryStatus to call _handleDisconnection when it fails update.
Updated ScannerScreen to manage navigation state logic on connection.