Closed
Conversation
Contributor
WalkthroughAdds explicit UTF-8 encoding to Java compilation by inserting "-encoding", "utf8" into javacOptions in build.mill’s BaseModule. No runtime logic or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
build.mill (3)
119-123: Prefer --release 11; use canonical UTF-8; drop trailing commaMore robust targeting across JDKs; clearer charset; consistent style.
- def javacOptions = Seq( - "-source", "11", - "-target", "11", - "-encoding", "utf8", - ) + def javacOptions = Seq( + "--release", "11", + "-encoding", "UTF-8" + )
110-117: Also set scalac encodingKeep Scala sources consistent with Java.
def scalacOptions = Seq( "-deprecation", "-feature", "-unchecked", "-language:implicitConversions", "-language:postfixOps", - "-language:reflectiveCalls" + "-language:reflectiveCalls", + "-encoding", "UTF-8" )
138-155: Propagate encoding to testsBaseTestModule doesn’t inherit BaseModule’s options; consider mixing it in or adding the same -encoding flags here to avoid drift.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
build.mill(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (15)
- GitHub Check: cloud_gcp_tests
- GitHub Check: cloud_aws_tests
- GitHub Check: join_tests
- GitHub Check: groupby_tests
- GitHub Check: analyzer_tests
- GitHub Check: streaming_tests
- GitHub Check: kv_store_tests
- GitHub Check: spark_tests
- GitHub Check: stats_tests
- GitHub Check: flink_tests
- GitHub Check: udafs_tests
- GitHub Check: online_tests
- GitHub Check: batch_tests
- GitHub Check: fetcher_tests
- GitHub Check: enforce_triggered_workflows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Summary by CodeRabbit