chore: expose more flate2 feature flags#476
Conversation
Summary of ChangesHello @JakubKoralewski, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the flexibility of the crate's compression capabilities by exposing additional feature flags related to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a nice enhancement, exposing two new feature flags, deflate-flate2-zlib-ng and deflate-flate2-zlib-ng-compat, to allow using the zlib-ng backend from flate2. This gives users more options for performance tuning. I've added one suggestion to Cargo.toml to add comments for the new features, which will improve consistency and maintainability. Additionally, since these are new user-facing features, please consider documenting them in the README.md file's 'Features' section to help users discover and use them.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
zlib-ng worked better for me, so I exposed it as a feature flag