feat: Add support for time::PrimitiveDateTime#322
Merged
Pr0methean merged 1 commit intozip-rs:masterfrom Mar 23, 2025
Merged
Conversation
Pr0methean
previously approved these changes
Mar 22, 2025
Mark `TryFrom<OffsetDateTime> for DateTime` and `TryFrom<DateTime> for OffsetDateTime` as deprecated.
b0d56a0 to
f1114f3
Compare
Contributor
Author
|
Resolve conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark
TryFrom<OffsetDateTime> for DateTimeandTryFrom<DateTime> for OffsetDateTimeas deprecated. Thedeprecatedattribute have no effect on trait implementations. However, I think it would be better for this attribute to exist for humans, so I add it. I think it would be better to removeTryFrom<OffsetDateTime> for DateTimeandTryFrom<DateTime> for OffsetDateTimein the future.Closes #321