-
Notifications
You must be signed in to change notification settings - Fork 104
Closed
Labels
Amazon Q development agentGenerate new features or iterate code based on issue descriptions and comments.Generate new features or iterate code based on issue descriptions and comments.LZMAbugSomething isn't workingSomething isn't working
Description
Hello! Thank you for the library! I found a bug in the implementation of LZMA compression-decompression. I can't share archive were it reproduces. Anyway I found specification.
5.8.8 Storage fields for the property information within the LZMA
Properties Header are as follows:
LZMA Version Information 2 bytes
LZMA Properties Size 2 bytes
LZMA Properties Data variable, defined by "LZMA Properties Size"
Link: https://pkwaredownloads.blob.core.windows.net/pem/APPNOTE.txt
We can see, first 2 bytes store LZMA version information.
Python implementation: https://github.com/python/cpython/blob/main/Lib/zipfile/__init__.py#L738
7-Zip implementation: https://github.com/mcmilk/7-Zip/blob/master/CPP/7zip/Archive/Zip/ZipHandler.cpp#L814
С++ implementation: https://bitbucket.org/wbenny/ziplib/src/176e4b6d51fc913fc7f7fb44df8f946374dc2c0c/Source/ZipLib/compression/lzma/lzma_decoder.h#lines-68
Link to source code:
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Amazon Q development agentGenerate new features or iterate code based on issue descriptions and comments.Generate new features or iterate code based on issue descriptions and comments.LZMAbugSomething isn't workingSomething isn't working