This repository was archived by the owner on Jun 2, 2024. It is now read-only.
Add rs versions of bzip and zstd in order to pass static compiles#429
Closed
lolpro11 wants to merge 2 commits intozip-rs:masterfrom
Closed
Add rs versions of bzip and zstd in order to pass static compiles#429lolpro11 wants to merge 2 commits intozip-rs:masterfrom
lolpro11 wants to merge 2 commits intozip-rs:masterfrom
Conversation
Member
|
Replaced by zip-rs/zip2#58. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bzip-sys and Zstd-sys are the only two packages that require dynamic linking to system libs.
In order to pass a static compile (for use in containers), I recommend using a pure Rust impl of these compression algorithms.
Zstud seems to be using ffi functions, but it does produce a static lib. It does use system libs for compiling, which should be fine.