look for clang-cpp shared lib when it exists#4993
Merged
Conversation
This was referenced Apr 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a much less invasive change than #4992. It makes zig build successfully against homebrew's clang package.
#4992 is blocked on an apt.llvm.org packaging issue, as well as the docker images giving this error:
So the cmake-based configuration is really a no-go. I also don't like how non-standard that is.
See #4799. The homebrew parts of this are solved by this PR, however, the issue remains open due to https://bugs.llvm.org/show_bug.cgi?id=44870.