Implement non-exhaustive enums #4191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* error for '_' prong on exhaustive enum * todo panic for `@tagName` on non-exhaustive enum * don't require '_' field on tagged unions
LemonBoy
reviewed
Jan 15, 2020
andrewrk
reviewed
Jan 15, 2020
Member
andrewrk
left a comment
There was a problem hiding this comment.
Nice, this is substantial language progress.
daurnimator
reviewed
Jan 15, 2020
daurnimator
reviewed
Jan 16, 2020
LemonBoy
reviewed
Jan 16, 2020
src/analyze.cpp
Outdated
| add_node_error(g, field_node, buf_sprintf("non-exhaustive enum must specify size")); | ||
| enum_type->data.enumeration.resolve_status = ResolveStatusInvalid; | ||
| } | ||
| if (field_count > 1 && log2_u64(field_count - 1) == enum_type->size_in_bits) { |
Contributor
There was a problem hiding this comment.
Isn't this impossible to trigger for a non-extern enum? The enum tag size is chosen before the _ field is skipped.
Moreover the field_count is now invalid and enumeration.fields contains one entry too many.
Member
Author
There was a problem hiding this comment.
Tag size must be specified for non-exhaustive enums so it is possible to hit.
const E = enum(u2) {
a,
b,
c,
d,
_, // error: non-exhaustive enum specifies every value
};a3faf7c to
6c8f01d
Compare
andrewrk
approved these changes
Jan 16, 2020
Member
andrewrk
left a comment
There was a problem hiding this comment.
Nice work! I consider this to be mergeable right now, but I'll leave it up to you if you want to take the test case suggestion before I hit the button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2524
Any suggestions to improve the documentation are welcome.