Conversation
Add LLVM_STATIC and update README.md.
| And if statically linking LLVM: | ||
| ``` | ||
| cmake .. -DCMAKE_PREFIX_PATH=$HOME/local -DLLVM_STATIC=on | ||
| ``` |
There was a problem hiding this comment.
Correct me if I'm wrong but this section only applies when -DCMAKE_BUILD_TYPE=Debug is also passed? Release builds seem to link statically against llvm.
|
Can you describe what problem you are trying to solve? |
|
i thought that was the status quo? |
andrewrk
left a comment
There was a problem hiding this comment.
Thanks for the patch @winksaville. I'm on board with this new option but I have some strong opinions about the way to expose it and the documentation - see review comments.
| # git log -p -- deps/lld | ||
| option(ZIG_FORCE_EXTERNAL_LLD "If your system has the LLD patches use it instead of the embedded LLD" OFF) | ||
|
|
||
| set(LLVM_STATIC off CACHE BOOL "Link LLVM statically") |
There was a problem hiding this comment.
Let's put this next to the corresponding ZIG_STATIC option, rename it to ZIG_STATIC_LLVM, and improve the documentation string. "Prefer linking against static LLVM libraries".
|
Please feel free to re-open this PR with the requested changes. |
Add LLVM_STATIC and update README.md.