CI: make Windows build from source like every other system#13802
Merged
CI: make Windows build from source like every other system#13802
Conversation
When building with LLVM, always do -lole32 -lversion -luuid even when using the cmake-provided build stuff. Otherwise we get undefined symbols when linking.
c83c636 to
1122d9d
Compare
Contributor
|
In case the OOM issue comes up again, there is a handy GitHub action for increasing the swap space: https://github.com/al-cheb/configure-pagefile-action We are using it to build flang in MSYS2 CI for example, which peaks at ~12GB IIRC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that OOM is no longer a problem, the Windows CI can do the same process every other system does instead of building from a recent Zig binary.