Properly reset error return trace index#12825
Closed
Vexu wants to merge 2 commits intoziglang:masterfrom
Closed
Conversation
Member
Author
|
Hmm, this still doesn't handle this case properly: const std = @import("std");
test {
return error.SkipZigTest;
}
fn foo() !void {
return error.DontShow;
}
test {
foo() catch {
foo() catch {};
std.debug.dumpStackTrace(@errorReturnTrace().?.*);
};
}Maybe it'd be better to start off with a simplified version which always resets to zero since it handles all the common cases properly. |
019feed to
fa5d844
Compare
Contributor
Not sure if this is good news or bad, but I'm just finishing up an overlapping change that should handle that case correctly. It intends to implement the rest of #1923 (comment) (esp. supporting Let me know how we can best coordinate the follow-up change so that I don't step on your toes here 🙂 |
Member
Author
|
If you have a more complete fix then let's go with that, I just want this annoyance fixed to get the full benefit of #12807 |
Member
Author
|
Closing in favor of the more complete solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently depends on #12807 to free up two Zir instruction slots, only the last commit is relevant to this PR.
Example:
With the comment:
Uncommented:
Closes #1923