You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks @motiejus! Do you mind if I add a few tweaks to your proposed solution? Namely, I don't want the linker fail prematurely until it resolves all of the symbols first, and then the priority should be to fail with UndefinedSymbolReference before failing with FrameworkNotFound. This should give the user a better idea what symbols were unresolved if any. In case we are able to resolve every symbol but fail to find a framework that might be used at runtime, we then fail with FrameworkNotFound.
Thanks @motiejus! Do you mind if I add a few tweaks to your proposed solution? Namely, I don't want the linker fail prematurely until it resolves all of the symbols first, and then the priority should be to fail with UndefinedSymbolReference before failing with FrameworkNotFound. This should give the user a better idea what symbols were unresolved if any. In case we are able to resolve every symbol but fail to find a framework that might be used at runtime, we then fail with FrameworkNotFound.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
-frameworkis requested, but not found, the linker will errinstead of creating a strange executable.
#10299 (comment)
Refs #9542
Refs #10299
Refs #10158