feat: allow parsing Bitcoin deposit memo with inscription and add E2E test for parsing#2727
Closed
bitSmiley wants to merge 48 commits intozeta-chain:developfrom
Closed
feat: allow parsing Bitcoin deposit memo with inscription and add E2E test for parsing#2727bitSmiley wants to merge 48 commits intozeta-chain:developfrom
bitSmiley wants to merge 48 commits intozeta-chain:developfrom
Conversation
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Contributor
|
It seems it breaks the deposit BTC test: https://github.com/zeta-chain/node/actions/runs/10471358149/job/28998509065 Is the change supposed to be backward compatible |
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Contributor
Author
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Contributor
Contributor
Author
|
@lumtis sorry man, I just fixed the linting and change log, please help run the pipeline again. |
8 tasks
Contributor
|
Opening back for |
lumtis
approved these changes
Sep 14, 2024
fbac
approved these changes
Sep 19, 2024
Contributor
|
Closing in favor of #2957 as discussed on Slack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding e2e test for detecting memo from inscription.
The current
btcutildoes not have enough tapscript support, in this case, a nodejs sidecar to handle inscription txn generation is used instead. This is not intrusive and can be quickly removed once btcutil is upgraded.How Has This Been Tested?
Summary by CodeRabbit
New Features
ScriptBuilderfor constructing tapscripts used in Bitcoin transactions.Bug Fixes
Documentation
tsconfig.jsonfor TypeScript setup.Chores