🐛 fix(infra): upgrade LocalStack to 4.14.0 for CFN deletion fix#262
Merged
sodre merged 1 commit intoFeb 28, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
=======================================
Coverage 92.21% 92.21%
=======================================
Files 36 36
Lines 7831 7831
=======================================
Hits 7221 7221
Misses 610 610
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
463a898 to
8c60b9b
Compare
Pin LocalStack image from :4 (floating) to :4.14 (minor-locked) across CLI, docker-compose.yml, CI workflows, and docs. This resolves issue #81 where LocalStack confused CloudFormation templates during stack deletion. With the fix in place, the defensive try/except around delete_stack() in test teardown is no longer needed and has been removed from all 7 test files. Also fixed the docstring sample output in the `local status` command to reflect the pinned image version. Closes #81 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
8c60b9b to
7819dd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
LocalStack's v2 CloudFormation engine incorrectly tries to resolve
!GetAttreferences during stack deletion, even for resources that were never created due to theirConditionevaluating tofalse.Upstream issue: localstack/localstack#13609
Minimal reproduction: Posted at localstack/localstack#13609 (comment)
Status
🚧 WIP - Waiting for LocalStack 4.14.0 to be released with the fix.
Test plan
Fixes #81
🤖 Generated with Claude Code