feat: enforce entity name requirements#63
Merged
davemoore- merged 1 commit intozentity-io:masterfrom Feb 3, 2021
Merged
Conversation
ececeb7 to
f00a727
Compare
Contributor
Author
|
Sorry about the repeated pushes, keep committing pieces of our fork 🤦🏼♂️ should be final now. |
Contributor
Author
|
Rebasing to fix conflicts.. |
f00a727 to
6c20792
Compare
6c20792 to
bd68a48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the ES index naming requirements, this PR brings in validation to entity types, based on the ES implementation. This enforces the name requirements on create and update model methods, which is aligned with Elasticsearch's somewhat lenient handling of index names:
Closes #58