Skip to content

feature-bulk-resolution-enhancements#84

Merged
davemoore- merged 1 commit intomainfrom
feature-bulk-resolution-enhancements
Mar 5, 2021
Merged

feature-bulk-resolution-enhancements#84
davemoore- merged 1 commit intomainfrom
feature-bulk-resolution-enhancements

Conversation

@davemoore-
Copy link
Copy Markdown
Member

@davemoore- davemoore- commented Mar 4, 2021

@austince While working on examples for the docs, I found an optimization issue that I decided was worth fixing now. My changes are listed below -- the first item is what prompted me to address the change now:

  • POST _zentity/resolution/{entity_type}/_bulk now retrieves the entity model once before all jobs, instead of once before each job. If the "entity_type" is not given in the URL, then each job will fetch its own entity model, unless the job has the model embedded in its payload.
  • Ensure that an "entity_type" in a single bulk action overrides the "entity_type" in the URL.
  • Ensure that an embedded "model" is accepted when "entity_type" is undefined.
  • Fail the entire bulk request if the "entity_type" in the URL is not found, but allow single bulk actions to fail without failing the whole request if the action's own "entity_type" is not found.
  • Fixed a potential NullPointerException in JSON serialization.
  • Removed a needless log message.

… model once before all jobs, instead of once before each job. Ensure that an "entity_type" in a bulk resolution action overrides the "entity_type" in the URL. Fixed a potential NullPointerException in JSON serialization. Removed a needless log message.
Copy link
Copy Markdown
Contributor

@austince austince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a bunch of good catches!

@davemoore- davemoore- merged commit 817d324 into main Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants