Merged
Conversation
… model once before all jobs, instead of once before each job. Ensure that an "entity_type" in a bulk resolution action overrides the "entity_type" in the URL. Fixed a potential NullPointerException in JSON serialization. Removed a needless log message.
austince
approved these changes
Mar 5, 2021
Contributor
austince
left a comment
There was a problem hiding this comment.
Looks like a bunch of good catches!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@austince While working on examples for the docs, I found an optimization issue that I decided was worth fixing now. My changes are listed below -- the first item is what prompted me to address the change now:
POST _zentity/resolution/{entity_type}/_bulknow retrieves the entity model once before all jobs, instead of once before each job. If the "entity_type" is not given in the URL, then each job will fetch its own entity model, unless the job has the model embedded in its payload.