Skip to content

Add Supply Cargo Attributes#753

Merged
ampersand38 merged 6 commits intozen-mod:masterfrom
ampersand38:attributes-supplies
Nov 17, 2023
Merged

Add Supply Cargo Attributes#753
ampersand38 merged 6 commits intozen-mod:masterfrom
ampersand38:attributes-supplies

Conversation

@ampersand38
Copy link
Copy Markdown
Member

When merged this pull request will:

  • Add attributes for supply vehicles to adjust their supply cargo

@ampersand38 ampersand38 added the feature Adds a new feature label Oct 11, 2023
Comment thread addons/attributes/stringtable.xml Outdated
<English>Repair Cargo</English>
</Key>
<Key ID="STR_ZEN_Attributes_SupportCargo_Tooltip">
<English>Cargo to supply to other vehicles.</English>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this tooltip necessary?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can certainly be removed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds a bit too generic. I guess we can either remove or add more specific tooltips.

@mharis001 mharis001 added this to the 1.15.0 milestone Oct 20, 2023
@mharis001
Copy link
Copy Markdown
Member

Also, should add settings to enable/disable these like other attributes.

Copy link
Copy Markdown
Member

@mharis001 mharis001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@ampersand38 ampersand38 merged commit 07031ba into zen-mod:master Nov 17, 2023
@ampersand38 ampersand38 deleted the attributes-supplies branch November 17, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants