Merged
Conversation
Contributor
|
Mmmm, I like the sound of that even without the vid. |
Member
|
Could be bound to U by default, which is used in Reforger. |
Kexanone
requested changes
Apr 16, 2023
Kexanone
approved these changes
Apr 18, 2023
mharis001
requested changes
Apr 19, 2023
Member
|
I added a custom ping animation that grows the icon and fades it out near the end as well as being unique per curator and displaying their name. Also, using our own logic for viewing the ping (moving camera), which is mostly the same as base game for positions but different for objects. Finally, switched back to "Zeus" instead of "Curators" in the stringtable but not sure about the plural for "Zeus" so opted for "Zeus curators" in the description. @ampersand38 and @Kexanone please review and merge when ready. |
mharis001
approved these changes
May 12, 2023
rautamiekka
reviewed
May 12, 2023
rautamiekka
reviewed
May 12, 2023
rautamiekka
reviewed
May 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: