Add settings to toggle attributes#716
Merged
mharis001 merged 14 commits intozen-mod:masterfrom May 21, 2023
Merged
Conversation
Member
|
I like the idea of having settings for enabling/disabling attributes but not sure about limiting it to only certain ones. A more generalized approach (like the faction filter) might be better but I can foresee some weird UX cases with this option for the "sub-attributes menus" and the buttons used to access them. |
Kexanone
approved these changes
Apr 25, 2023
Member
Author
|
Ah, I was gonna get around to adding the settings to more attributes and see what mharis thought xD |
Member
Author
|
|
mharis001
requested changes
Apr 28, 2023
mharis001
reviewed
Apr 28, 2023
mharis001
reviewed
Apr 28, 2023
Member
|
I added the remaining attributes/buttons including those in other components. A bit of a mess, but I guess there isn't really a better way. |
mharis001
approved these changes
May 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: