Skip to content

Add Advanced Rappelling compatibility#700

Merged
Kexanone merged 10 commits intomasterfrom
advanced-rappelling-compat
Apr 11, 2023
Merged

Add Advanced Rappelling compatibility#700
Kexanone merged 10 commits intomasterfrom
advanced-rappelling-compat

Conversation

@Kexanone
Copy link
Copy Markdown
Member

@Kexanone Kexanone commented Jan 14, 2023

When merged this pull request will:

  • Add compatibility addon for using Duda's Advanced Rappelling for fast-roping waypoint and reinforcements.
  • Slightly refactor fastroping in main addon

@Kexanone Kexanone added the feature Adds a new feature label Jan 14, 2023
@Kexanone
Copy link
Copy Markdown
Member Author

Kexanone commented Jan 14, 2023

To Do: Get reinforcements working

@mharis001
Copy link
Copy Markdown
Member

Maybe these should be two separate waypoints (Fastrope and Advanced Rappel) because the mods could be run together. We could add conditions to waypoints so that they only show if the required mods are loaded.

@Kexanone
Copy link
Copy Markdown
Member Author

Kexanone commented Jan 19, 2023

Sounds like a good alternative approach. Would you propose the AR waypoint in a compat. or part of the main addon? If I remember correctly we decided against having anything but ACE as soft dependency in the main addon, that's why I went the compat. route in the first place.

@mharis001
Copy link
Copy Markdown
Member

Yeah, I think we can revisit that decision for some other big mods. I think both a new component (separation of features/responsibilities) or just in the ai component are good options. With waypoint conditions, this feature could be added without a hard dependency.

@mharis001 mharis001 added this to the 1.14.0 milestone Apr 3, 2023
@mharis001
Copy link
Copy Markdown
Member

I separated out the waypoints into "Fastrope" and "Rappel" and reworked how reinforcements handles the different insertion methods for air vehicles. I think we should keep the Advanced Rapelling compatibility as a separate optional component.

@mharis001
Copy link
Copy Markdown
Member

@Kexanone, I think this is good to go. Please look over my changes and merge when ready.

@Kexanone
Copy link
Copy Markdown
Member Author

Kexanone commented Apr 11, 2023

Looks good to me, but still needs to be tested if you haven't already.

@mharis001
Copy link
Copy Markdown
Member

I did the usual testing, and everything seemed okay. I think we are good to merge.

@Kexanone Kexanone merged commit 0dca83f into master Apr 11, 2023
@Kexanone Kexanone deleted the advanced-rappelling-compat branch April 11, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants