Skip to content

Custom Modules - Various improvements#685

Merged
mharis001 merged 2 commits intomasterfrom
custom-module-improvements
Nov 16, 2022
Merged

Custom Modules - Various improvements#685
mharis001 merged 2 commits intomasterfrom
custom-module-improvements

Conversation

@mharis001
Copy link
Copy Markdown
Member

@mharis001 mharis001 commented Oct 1, 2022

When merged this pull request will:

  • Various minor improvements to the custom modules component
    • Increase max number of modules to 200
    • Do not cache categories array as those could change if curatorAddons are changed
    • Reload the display if adding modules while the display is already opened
    • Use tvSortAll and do not use __EVAL - probably allows for better compatibility with build tools
  • Add new reloadDisplay common function
    • Use this for faction filter and reload display keybind

@mharis001 mharis001 added the enhancement Improves an existing feature label Oct 1, 2022
@mharis001 mharis001 added this to the 1.13.0 milestone Oct 1, 2022
@mharis001 mharis001 merged commit dabbe64 into master Nov 16, 2022
@mharis001 mharis001 deleted the custom-module-improvements branch November 16, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neilzar neilzar neilzar approved these changes

@Kexanone Kexanone Kexanone approved these changes

Assignees

No one assigned

Labels

enhancement Improves an existing feature

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mharis001 @neilzar @Kexanone