Common - Filter for ACRE radio IDs when serializing objects#640
Common - Filter for ACRE radio IDs when serializing objects#640mharis001 merged 15 commits intozen-mod:masterfrom
Conversation
Kexanone
left a comment
There was a problem hiding this comment.
Thanks for the PR. Looks fine, but doesn't fix the issue yet for exporting mission SQF.
I guess your approach could also be applied to https://github.com/zen-mod/ZEN/blob/master/addons/common/functions/fnc_exportMissionSQF.sqf.
mharis001
left a comment
There was a problem hiding this comment.
If we go with this approach then I would want to add TFAR support (doesn't need to be in this PR). We could also try and hold out for the extended loadout framework proposed for CBA but not sure when (or if) that will be merged.
Overall, seems okay, but maybe we should have our own get/set loadout functions in common instead of duplicating code.
|
@mharis001 Also I'm not really sure if the |
Co-authored-by: Kex <kexanone@gmail.com>
Co-authored-by: Kex <kexanone@gmail.com>
Did it so its not just getUnitLoadout wrapped in a macro. Not necessary but helps maintain syntax highlighting |
mharis001
left a comment
There was a problem hiding this comment.
Looks good. Just some cleanup.
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
When merged this pull request will:
postInit.sqfacre_api_fnc_filterUnitLoadoutto remove replace ACRE radio IDs with base radios