Skip to content

Convert compositions to hashes#552

Merged
neilzar merged 16 commits intomasterfrom
hash-compositions
Sep 3, 2021
Merged

Convert compositions to hashes#552
neilzar merged 16 commits intomasterfrom
hash-compositions

Conversation

@neilzar
Copy link
Copy Markdown
Contributor

@neilzar neilzar commented Feb 13, 2021

When merged this pull request will:

  • Title
  • Should improve performance slightly as findif is no longer needed.

@neilzar neilzar added enhancement Improves an existing feature 2.02 Arma 3 2.02 labels Feb 13, 2021
@neilzar neilzar added this to the Backlog milestone Feb 13, 2021
Comment thread addons/compositions/functions/fnc_processTreeAdditions.sqf
@neilzar neilzar modified the milestones: Backlog, 1.11.0 Feb 23, 2021
Comment thread addons/compositions/XEH_preInit.sqf Outdated
@mharis001
Copy link
Copy Markdown
Member

Will check if tree additions are still processed correctly.

Comment thread addons/compositions/XEH_preInit.sqf Outdated
Comment thread addons/compositions/script_component.hpp
Comment thread addons/compositions/XEH_preInit.sqf Outdated
Comment thread addons/compositions/functions/fnc_openDisplay.sqf Outdated
Comment thread addons/compositions/functions/fnc_openDisplay.sqf Outdated
@neilzar neilzar force-pushed the hash-compositions branch from ebea983 to 02a6433 Compare June 8, 2021 12:33
@neilzar neilzar requested review from CreepPork and mharis001 June 8, 2021 16:02
Comment thread addons/compositions/functions/fnc_openDisplay.sqf
Comment thread addons/compositions/functions/fnc_openDisplay.sqf Outdated
Comment thread addons/compositions/functions/fnc_openDisplay.sqf
@mharis001
Copy link
Copy Markdown
Member

Doesn't correctly delete empty category hashes. I think this likely just needs to call removeFromTree with _deleteFromData as true in edit mode.

@mharis001 mharis001 removed this from the 1.11.0 milestone Jun 16, 2021
@mharis001 mharis001 added this to the 1.12.0 milestone Jun 16, 2021
@neilzar neilzar requested a review from mharis001 July 24, 2021 14:28
Copy link
Copy Markdown
Member

@mharis001 mharis001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as expected now. Just some style/cleanup suggestions.

Comment thread addons/compositions/functions/fnc_openDisplay.sqf Outdated
Comment thread addons/compositions/functions/fnc_openDisplay.sqf Outdated
Comment thread addons/compositions/functions/fnc_removeFromTree.sqf
Comment thread addons/compositions/functions/fnc_initDisplayCurator.sqf
Comment thread addons/compositions/functions/fnc_removeFromTree.sqf Outdated
Comment thread addons/compositions/functions/fnc_openDisplay.sqf Outdated
@neilzar neilzar requested a review from mharis001 September 2, 2021 20:10
Comment thread addons/compositions/functions/fnc_openDisplay.sqf Outdated
@neilzar neilzar merged commit a22ac29 into master Sep 3, 2021
@mharis001 mharis001 deleted the hash-compositions branch September 3, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.02 Arma 3 2.02 enhancement Improves an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants