Skip to content

Add a Radius option for custom dialog sliders#549

Merged
neilzar merged 32 commits intomasterfrom
dialog-slider-radius
Mar 10, 2021
Merged

Add a Radius option for custom dialog sliders#549
neilzar merged 32 commits intomasterfrom
dialog-slider-radius

Conversation

@neilzar
Copy link
Copy Markdown
Contributor

@neilzar neilzar commented Feb 12, 2021

When merged this pull request will:

  • Title
  • Draws a circle on the terrain to indicate the affected area.

@neilzar neilzar added the feature Adds a new feature label Feb 12, 2021
@neilzar neilzar added this to the Ongoing milestone Feb 12, 2021
@neilzar neilzar marked this pull request as ready for review February 16, 2021 00:26
@neilzar
Copy link
Copy Markdown
Contributor Author

neilzar commented Feb 16, 2021

I can't think of a reliable way to determine the module if the module coder didn't go with the _logic standard.

@neilzar neilzar modified the milestones: Ongoing, 1.11.0 Feb 16, 2021
@mharis001
Copy link
Copy Markdown
Member

mharis001 commented Feb 19, 2021 •
edited
Loading

I think this shouldn't use _logic as the hardcoded variable name. Instead, the center can be specified by providing an object or AGL position in the value info. That way the dialog can support any number of radius sliders.

Could also add an optional color parameter to value info.

@neilzar neilzar requested a review from mharis001 February 23, 2021 00:43
@neilzar neilzar added the 2.02 Arma 3 2.02 label Feb 23, 2021
mharis001
mharis001 reviewed Feb 23, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mharis001 mharis001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be better if the handling for the drawing was in gui_slider. The Draw3D EH could be self-cleaning and use the slider position.

Comment thread addons/dialog/functions/fnc_create.sqf Outdated
Comment thread addons/dialog/functions/fnc_create.sqf Outdated
@neilzar neilzar requested a review from mharis001 February 23, 2021 12:17
@neilzar neilzar removed the 2.02 Arma 3 2.02 label Feb 23, 2021
mharis001
mharis001 reviewed Feb 25, 2021
View reviewed changes
Comment thread addons/dialog/functions/fnc_gui_slider.sqf Outdated
Comment thread addons/dialog/functions/fnc_gui_slider.sqf Outdated
Comment thread addons/dialog/functions/fnc_gui_slider.sqf Outdated
Comment thread docs/frameworks/dynamic_dialog.md Outdated
Comment thread addons/dialog/functions/fnc_create.sqf Outdated
Comment thread addons/dialog/functions/fnc_gui_slider.sqf Outdated
@neilzar neilzar requested a review from mharis001 February 25, 2021 13:49
mharis001
mharis001 reviewed Feb 26, 2021
View reviewed changes
Comment thread addons/dialog/functions/fnc_gui_slider.sqf Outdated
Comment thread addons/dialog/functions/fnc_gui_slider.sqf Outdated
mharis001
mharis001 reviewed Feb 26, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mharis001 mharis001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should maybe add some scaling to the dots spacing since with larger radii a very large amount of dots are drawn. For example, with a radius of 1000 m, 1256 dots are drawn.

Comment thread docs/frameworks/dynamic_dialog.md Outdated
Comment thread docs/frameworks/dynamic_dialog.md
Comment thread docs/frameworks/dynamic_dialog.md Outdated
Comment thread addons/dialog/functions/fnc_gui_slider.sqf Outdated
Comment thread addons/modules/functions/fnc_moduleEarthquake.sqf Outdated
CreepPork
CreepPork reviewed Mar 4, 2021
View reviewed changes
Comment thread addons/modules/functions/fnc_moduleEarthquake.sqf Outdated
@neilzar neilzar requested review from CreepPork and mharis001 March 8, 2021 23:56
mharis001
mharis001 reviewed Mar 9, 2021
View reviewed changes
Comment thread docs/frameworks/dynamic_dialog.md Outdated
Comment thread addons/dialog/functions/fnc_gui_slider.sqf Outdated
@neilzar neilzar merged commit d56beed into master Mar 10, 2021
@neilzar neilzar deleted the dialog-slider-radius branch March 10, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CreepPork CreepPork CreepPork approved these changes

@mharis001 mharis001 mharis001 approved these changes

Assignees

No one assigned

Labels

feature Adds a new feature

Projects

None yet

Milestone

1.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@neilzar @mharis001 @CreepPork