Add Unload Vehicle Cargo keybind and context menu action#528
Merged
neilzar merged 18 commits intozen-mod:masterfrom Feb 7, 2021
Merged
Add Unload Vehicle Cargo keybind and context menu action#528neilzar merged 18 commits intozen-mod:masterfrom
neilzar merged 18 commits intozen-mod:masterfrom
Conversation
Add viv cargo unloading functionality to Eject Passengers keybind. In-selection viv cargo will be unloaded from carriers, carriers will have all viv cargo unloaded.
Member
|
I'd rather see this as a separate keybind instead of part of the eject passengers one. |
Member
Author
What about a module and/or a Vehicle Logistics menu item? |
Member
|
I think a module isn't convenient and likely overkill for this action. As for a context menu action, I am unsure but I think a keybind provides faster, more convenient access. |
CreepPork
requested changes
Jan 25, 2021
Member
|
A separate keybind would be great, but one with a similar keybind to the eject one. You sometimes would only want to eject the cargo or passengers. |
Co-authored-by: Ralfs Garkaklis <ralfs@garkaklis.com>
Co-authored-by: Ralfs Garkaklis <ralfs@garkaklis.com>
mharis001
reviewed
Jan 26, 2021
Member
mharis001
left a comment
There was a problem hiding this comment.
Works well. Just some cleanup suggestions.
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
…into unload-viv-cargo
mharis001
reviewed
Jan 26, 2021
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
…into unload-viv-cargo
mharis001
approved these changes
Jan 27, 2021
CreepPork
reviewed
Jan 27, 2021
neilzar
approved these changes
Feb 6, 2021
CreepPork
approved these changes
Feb 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: