Merged
Conversation
Member
|
Seems to work well in "vanilla", but we might want to check some more mods. |
neilzar
approved these changes
Jan 13, 2021
Contributor
neilzar
left a comment
There was a problem hiding this comment.
Confirmed to work with all RHS mods and 3CB factions, so I'd say all mods should work.
Kexanone
approved these changes
Jan 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
faction_filtercomponentmodeChangedandsideChangedeventsWorks well when tested with popular asset mods. Deals with the following object categorization trickiness (for Zeus):
sideofCfgFactionClassesdoesn't determine under which side an object is sorted.editorCategorycan also be used to categorize an object (although generally not used for characters and vehicles).As a result, we don't use
CfgFactionClassesdirectly and instead scanCfgPatchesunitsarrays andCfgGroupsto find factions.