Skip to content

use configOf instead of typeOf config lookup#482

Merged
neilzar merged 3 commits intomasterfrom
dev-branch-changes
Oct 15, 2020
Merged

use configOf instead of typeOf config lookup#482
neilzar merged 3 commits intomasterfrom
dev-branch-changes

Conversation

@neilzar
Copy link
Copy Markdown
Contributor

@neilzar neilzar commented Oct 15, 2020

When merged this pull request will:

  • Use configOf that was introduced in 2.00, it is twice as fast as using typeOf in a config lookup.

@mharis001
Copy link
Copy Markdown
Member

mharis001 commented Oct 15, 2020

Should also bump REQUIRED_VERSION.

@mharis001 mharis001 added the optimization Makes performance improvements label Oct 15, 2020
@mharis001 mharis001 added this to the 1.10.0 milestone Oct 15, 2020
@neilzar neilzar merged commit 051a953 into master Oct 15, 2020
@mharis001 mharis001 deleted the dev-branch-changes branch October 15, 2020 21:41
@shukari shukari mentioned this pull request Oct 16, 2020
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CreepPork CreepPork CreepPork approved these changes

@mharis001 mharis001 mharis001 approved these changes

Assignees

No one assigned

Labels

optimization Makes performance improvements

Projects

None yet

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@neilzar @mharis001 @CreepPork