Skip to content

fix: closes #7274 - Fixed mouses simulating swipes with Forward and B…#7672

Merged
mr-cheffy merged 2 commits intozen-browser:devfrom
mathieutu:dev
Apr 17, 2025
Merged

fix: closes #7274 - Fixed mouses simulating swipes with Forward and B…#7672
mr-cheffy merged 2 commits intozen-browser:devfrom
mathieutu:dev

Conversation

@mathieutu
Copy link
Contributor

@mathieutu mathieutu commented Apr 17, 2025

Hi,

Firstly, thanks for this amazing work! This browser is a 💎, and it's an honour to contribute to such a project!

On several mouses, and mouses customization softwares (like Logitech Option +, or Better Mouse), the Back and Forward event are emulated by sending a Left or Right SwipeEvent.

This blocks the usage of these buttons to switch workspace due to the way the events were previously handled.

This PR fixes the issue.

Tested with a Logitech MX Vertical, and a MacBookPro Trackpad.

Thanks!

fix #7274

@mathieutu mathieutu requested a review from mr-cheffy April 17, 2025 08:52
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. Bug labels Apr 17, 2025
Copy link
Member

@mr-cheffy mr-cheffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great from my side!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 17, 2025
@mr-cheffy mr-cheffy merged commit 2c85a85 into zen-browser:dev Apr 17, 2025
@Blendertom
Copy link

@mathieutu
Is this still working for you?

I just did a clean install and this no longer works for me consistently. It will sometimes randomly work if I start scrolling with my trackpad, and then right after that I scroll with the thumb wheel.

@mathieutu
Copy link
Contributor Author

@Blendertom I did not reinstall the mouse software, so I can't say right now, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MX Master 3 Forward/Back Mouse Buttons Don't Work For Switching Workspaces While Logi Options+ is Installed

3 participants