Skip to content

Fixed tab background overlapping#308

Merged
mr-cheffy merged 2 commits intozen-browser:mainfrom
n7itro:main
Aug 18, 2024
Merged

Fixed tab background overlapping#308
mr-cheffy merged 2 commits intozen-browser:mainfrom
n7itro:main

Conversation

@n7itro
Copy link
Contributor

@n7itro n7itro commented Aug 18, 2024

Added bottom margin to tabs so tab backgrounds don't overlap with each other. Closes #303

Added bottom margin to tabs so tab backgrounds don't overlap with each other. Closes #303
@n7itro n7itro requested a review from mr-cheffy August 18, 2024 13:34
Copy link
Member

@mr-cheffy mr-cheffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add the important

@n7itro
Copy link
Contributor Author

n7itro commented Aug 18, 2024

How does it look?

Before:
image

After:
image

@mr-cheffy
Copy link
Member

Please remove the important

@mr-cheffy mr-cheffy merged commit 0f0cc0e into zen-browser:main Aug 18, 2024
@mr-cheffy
Copy link
Member

Does it work without the important btw?

@n7itro
Copy link
Contributor Author

n7itro commented Aug 18, 2024

Does it work without the important btw?

When tested in the Browser Toolbox it requires !important but I'm not sure whether that applies here

@mr-cheffy
Copy link
Member

In the browser toolbox, in the same sector and file you added this one?

@n7itro
Copy link
Contributor Author

n7itro commented Aug 18, 2024

I tested it in vertical-tab.css and it doesn't require it.

@mr-cheffy
Copy link
Member

Perfect, thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tab padding overlaps

2 participants