Fix: Pinned tab state and favicon handling#2853
Merged
mr-cheffy merged 1 commit intozen-browser:devfrom Nov 11, 2024
Merged
Conversation
Fixes several issues related to pinned tab restoration and favicon display: - Ensures pinned tabs are not loaded in private windows. - Improves favicon caching and setting for pinned tabs. - Fixes an issue where the tab state was not properly restored, leading to incorrect icons and titles. - Uses base64 encoded favicon data to prevent issues with favicon loading and updates the favicon loading logic to be more robust. - Adds a call to `gBrowser._updateTabBarForPinnedTabs` to ensure the tab bar is updated correctly after restoring pinned tabs, which fixes a UI issue where the tab bar wouldn't refresh properly until interacted with. - Improves tab initialization by explicitly calling `newTab.initialize()` after restoring a pinned tab. This fixes an issue with tabs not rendering icon and label after being restored. The changes improve the reliability of pinned tab restoration and ensure that favicons are displayed correctly.
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes several issues related to pinned tab restoration and favicon display:
gBrowser._updateTabBarForPinnedTabsto ensure the tab bar is updated correctly after restoring pinned tabs, which fixes a UI issue where the tab bar wouldn't refresh properly until interacted with.newTab.initialize()after restoring a pinned tab. This fixes an issue with tabs not rendering icon and label after being restored.The changes improve the reliability of pinned tab
restoration and ensure that favicons are displayed correctly.