Now asking for value of missing environment variables#645
Merged
Conversation
matheuss
requested changes
Jun 8, 2017
| } | ||
|
|
||
| console.log( | ||
| '> Please enter the values for the following environment variables:' |
Contributor
There was a problem hiding this comment.
Please use the info helper 🙏
| nowConfig.env = await envFields(nowConfig.env) | ||
| } | ||
|
|
||
| console.log(nowConfig.env) |
Contributor
There was a problem hiding this comment.
This shouldn't be here right 😅
| // Merge `now.env` from package.json with `-e` arguments. | ||
| const pkgEnv = nowConfig && nowConfig.env | ||
|
|
||
| if (Array.isArray(nowConfig.env)) { |
Contributor
There was a problem hiding this comment.
This breaks deployments that don't have a now on package.json or a now.json:
Contributor
Author
|
Thank you, @matheuss. Applied your wishes! 😊 |
Contributor
Author
|
@matheuss Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If your
envconfig property contains an array instead of an object,nowwill ask you for the value of these environment variables. This makes the initial command much shorter (no-eneeded)!BEFORE
AFTER
Leads to (similar):
This is how we do it.