Expose Webpack resolve alias and modules properties#460
Expose Webpack resolve alias and modules properties#460shcca wants to merge 2 commits intovercel:masterfrom shcca:expose-webpack-resolve-alias-and-modules
Conversation
Codecov Report
@@ Coverage Diff @@
## master #460 +/- ##
=======================================
Coverage 74.68% 74.68%
=======================================
Files 13 13
Lines 395 395
=======================================
Hits 295 295
Misses 100 100
Continue to review full report at Codecov.
|
| // https://webpack.js.org/configuration/resolve/#resolvealias | ||
| resolveAlias: {}, // default | ||
| // https://webpack.js.org/configuration/resolve/#resolvemodules | ||
| resolveModules: [] // default |
There was a problem hiding this comment.
I think we want to avoid leaking webpack details through to the ncc API in case we need to swap webpack for rollup or some other alternative.
There was a problem hiding this comment.
Other tools likely have similar options; Rollup for sure does.
Changing build tool would definitely be a breaking change, if it ever happens, so I don't particularly see the issue with supporting a particular flavor of options.
This option would reduce my bundle by dropping 2 unused heavy sub-dependencies. I just realized that my built file is 1.2MB due a couple of dependencies I don't really use.
This is in regard to #459