Skip to content

edit_prediction: Skip cloud Zeta requests when not signed in (#57615) (cherry-pick to preview)#58045

Merged
zed-zippy[bot] merged 1 commit into
v1.5.xfrom
cherry-pick-v1.5.x-46845bf2
May 29, 2026
Merged

edit_prediction: Skip cloud Zeta requests when not signed in (#57615) (cherry-pick to preview)#58045
zed-zippy[bot] merged 1 commit into
v1.5.xfrom
cherry-pick-v1.5.x-46845bf2

Conversation

@zed-zippy

@zed-zippy zed-zippy Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Cherry-pick of #57615 to preview


Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX
    checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Closes #57962

What

When a user is not signed in to their Zed account, the edit prediction
system was still attempting a cloud API request on every keystroke. The
request would fail deep in the credential check
(CloudApiClient::build_request) with a ClientApiError::NotSignedIn
error, which propagated back up and was logged at ERROR level via
.log_err() at line 2389 of edit_prediction.rs.

Why

The sign-in check was happening too late — only discovered after async
tasks were already spawned and the full request pipeline entered. This
fix gates the request at the top of request_prediction_internal,
returning Task::ready(Ok(None)) immediately before any inputs are
built or tasks spawned.

The guard mirrors the existing is_cloud provider check already used
elsewhere in the same file, and only applies to the Zeta model on the
cloud provider path. Local providers (Ollama, OpenAiCompatibleApi) and
other models (Mercury, Fim) are unaffected.

Note: I haven't added a test for this — testing the early-return would
require mocking auth state, which I wasn't sure was worth the complexity
for a one-liner guard. Happy to add one if preferred.

Release Notes:

  • Fixed noisy not signed in error log on every keystroke when not
    signed in to Zed

Co-authored-by: Oleksiy Syvokon oleksiy@zed.dev
Co-authored-by: MrSubidubi finn@zed.dev
Co-authored-by: David3u 3udavid@gmail.com

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Closes #57962

## What

When a user is not signed in to their Zed account, the edit prediction
system was still attempting a cloud API request on every keystroke. The
request would fail deep in the credential check
(`CloudApiClient::build_request`) with a `ClientApiError::NotSignedIn`
error, which propagated back up and was logged at `ERROR` level via
`.log_err()` at line 2389 of `edit_prediction.rs`.

## Why

The sign-in check was happening too late — only discovered after async
tasks were already spawned and the full request pipeline entered. This
fix gates the request at the top of `request_prediction_internal`,
returning `Task::ready(Ok(None))` immediately before any inputs are
built or tasks spawned.

The guard mirrors the existing `is_cloud` provider check already used
elsewhere in the same file, and only applies to the `Zeta` model on the
cloud provider path. Local providers (Ollama, `OpenAiCompatibleApi`) and
other models (Mercury, Fim) are unaffected.

Note: I haven't added a test for this — testing the early-return would
require mocking auth state, which I wasn't sure was worth the complexity
for a one-liner guard. Happy to add one if preferred.

Release Notes:

- Fixed noisy `not signed in` error log on every keystroke when not
signed in to Zed

---------

Co-authored-by: Oleksiy Syvokon <oleksiy@zed.dev>
Co-authored-by: MrSubidubi <finn@zed.dev>
Co-authored-by: David3u <3udavid@gmail.com>
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 29, 2026
@zed-community-bot zed-community-bot Bot added the bot Pull requests authored by a bot label May 29, 2026
@zed-zippy zed-zippy Bot merged commit fcf0321 into v1.5.x May 29, 2026
41 checks passed
@zed-zippy zed-zippy Bot deleted the cherry-pick-v1.5.x-46845bf2 branch May 29, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot Pull requests authored by a bot cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants