settings_ui: Match all query words in search#56835
Merged
Merged
Conversation
Settings search treated multi-word queries as OR, so "tab size" matched any document whose words contained a prefix of "tab" or "size" — flooding results with unrelated entries like "Show Tab Bar" and "Maximum Tabs". Switch the exact-match filter to require every query word to have a prefix match in the document, and guard the empty query_words case so whitespace-only queries do not match every document (since `[].iter().all(...)` returns `true`).
probably-neb
approved these changes
May 15, 2026
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings search treated multi-word queries as OR, so “tab size” matched any document whose words contained a prefix of “tab” or “size” -- flooding results with unrelated entries like “Show Tab Bar” and “Maximum Tabs”.
Self-Review Checklist:
Closes #56244.
Release Notes: