agent_ui: Allow toggling profile selector during generation#56784
Merged
bennetbo merged 4 commits intoMay 15, 2026
Merged
Conversation
The idle guard prevented the keybinding from working while the agent was generating, even though the profile selector button in the UI remained clickable. Changing the profile affects future messages, not the in-flight response, so there is no reason to block it.
|
We require contributors to sign our Contributor License Agreement, and we don't have @Rfluid on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idle guard prevented the keybinding from working while the agent was generating, even though the profile selector button in the UI remained clickable. Changing the profile affects future messages, not the in-flight response, so there is no reason to block it.
Self-Review Checklist:
Closes #56704
Release Notes:
agent: toggle profile selectorkeybinding being ignored while the agent was generating a response.