Fix macOS find query seeding#56681
Merged
Merged
Conversation
9b129b0 to
385a3ec
Compare
ChristopherBiscardi
approved these changes
May 13, 2026
ChristopherBiscardi
left a comment
Contributor
There was a problem hiding this comment.
works as intended. Search bar now shows every time when using Cmd+E, which seems to be an intentional change.
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55619
Summary
buffer_search::UseSelectionForFindthroughBufferSearchBar::deployinstead of updating the query editor directly.deploy, so the Cmd-E action can forceSeedQuerySetting::Alwayswhile regular deploy callers continue to passNoneand respect the user’sseed_search_query_from_cursorsetting.deploy, Cmd-E now also runs the search path that keeps buffer-search navigation state in sync:search_suggestedsearch, which updates the query editor, search options, active search query, search history, and macOS find pasteboardsearchable_items_with_matchesandactive_match_indexsimulate_keystrokes("cmd-e")andsimulate_keystrokes("cmd-g").Validation
cargo test -p search test_cmd_e_then_cmd_g_uses_selection_for_findcargo fmt --check --package search --package zed_actions./script/check-keymapscargo check -p searchcargo check -p workspacecargo check -p vimRelease Notes: