git: Disable log.showSignature for internal commands#55708
Merged
Anthony-Eid merged 3 commits intoMay 16, 2026
Conversation
When users have `log.showSignature = true` configured globally, git prepends signature verification lines (e.g. "No signature\n", "gpg: Signature made ...") to stdout before the user-supplied --format output. This corrupted the null-byte-separated parsers used by `git show` and `git log --follow` paths, causing the "0 changed files" misreport in the git graph detail panel and breaking file history. Override the setting to false in build_command, mirroring the existing core.fsmonitor=false override. The flag is only meaningful for log/show/whatchanged so it has no effect on other commands. Closes zed-industries#53604
|
We require contributors to sign our Contributor License Agreement, and we don't have @toddlerer on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Contributor
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Anthony-Eid
approved these changes
May 16, 2026
Contributor
|
Thank you for fixing this! |
Contributor
Author
|
Thanks for the review and merge, and for the rationale comments on the neighboring overrides! |
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-Review Checklist:
Closes #53604.
When
log.showSignature = true, git prepends signature verification lines to stdout before the--formatoutput. The null-separated parsers incrates/git/src/repository.rsweren't expecting that, so SHAs ended up corrupted — the git graph detail panel showed "0 changed files" for every commit, and file history was similarly broken.Setting
-c log.showSignature=falseinbuild_commandis the same trick we already use forcore.fsmonitor. It only affects log/show/whatchanged, so other commands aren't touched.Verified locally with an SSH-signed repo: before this change the detail panel said "0 changed files"; after, the modified files show up correctly.
Release Notes:
log.showSignatureis enabled