Skip to content

settings: Fix inverted VS Code import for files.simpleDialog.enable#55678

Merged
agu-z merged 1 commit into
zed-industries:mainfrom
Earlopain:simpleDialog-import-invert
May 15, 2026
Merged

settings: Fix inverted VS Code import for files.simpleDialog.enable#55678
agu-z merged 1 commit into
zed-industries:mainfrom
Earlopain:simpleDialog-import-invert

Conversation

@Earlopain

Copy link
Copy Markdown
Contributor

Seems to have been introduced in 1fbe1e3. These settings actually mean the opposite:

Whether to use the system provided dialogs for Open and Save As. When set to false, Zed will use the built-in keyboard-first pickers.

Enables the simple file dialog for opening and saving files and folders. The simple file dialog replaces the system file dialog when enabled.

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Closes #ISSUE

Release Notes:

  • Fixed import of VSCode setting files.simpleDialog.enable being inverted

@cla-bot

cla-bot Bot commented May 4, 2026

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement, and we don't have @Earlopain on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@zed-community-bot zed-community-bot Bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label May 4, 2026
@maxdeviant maxdeviant changed the title fix: inverted vscode import for files.simpleDialog.enable settings: Fix inverted VS Code import for files.simpleDialog.enable May 4, 2026
@Earlopain

Copy link
Copy Markdown
Contributor Author

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 4, 2026
@cla-bot

cla-bot Bot commented May 4, 2026

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

Seems to have been introduced in zed-industries@1fbe1e3

These settings actually mean the opposite:

> Whether to use the system provided dialogs for Open and Save As. When set to false, Zed will use the built-in keyboard-first pickers.

> Enables the simple file dialog for opening and saving files and folders. The simple file dialog replaces the system file dialog when enabled.
@Earlopain Earlopain force-pushed the simpleDialog-import-invert branch from 8f32d6b to 06ea588 Compare May 4, 2026 18:53
@ChristopherBiscardi ChristopherBiscardi added area:settings Feedback for preferences, configuration, etc area:parity/vscode Feedback for VSCode parity features labels May 4, 2026
@agu-z agu-z self-assigned this May 15, 2026

@agu-z agu-z left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Merging...

@agu-z agu-z added this pull request to the merge queue May 15, 2026
Merged via the queue into zed-industries:main with commit 3bd9d13 May 15, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:parity/vscode Feedback for VSCode parity features area:settings Feedback for preferences, configuration, etc cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants