markdown_preview: Shrink preview to fit when pane toolbar grows#55009
Merged
Conversation
The outer `MarkdownPreviewView` div used `.size_full()`, so its height stayed at 100% of the pane regardless of the toolbar size. When the buffer search bar deployed, the toolbar grew by ~45px and the preview's bottom extended past the pane bottom, getting clipped by the pane's `overflow_hidden`. Switching to `.w_full().flex_1().min_h_0()` lets the preview take only the leftover main-axis space and shrink as the toolbar grows. After the fix, `bounds.size.height` round-trips `952px ↔ 907px` with the toolbar at `67 ↔ 112`, matching the available pane area.
|
We require contributors to sign our Contributor License Agreement, and we don't have @tkilaker on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Contributor
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
agu-z
approved these changes
May 15, 2026
agu-z
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Thank you for your contribution
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MarkdownPreviewViewdiv from.size_full()to.w_full().flex_1().min_h_0().overflow_hidden.Verified empirically:
bounds.size.heightround-trips952px ↔ 907pxwith the toolbar at67 ↔ 112(Δ = 45px = the search bar's height).Companion to #55008 (anchor compensation). Both PRs come out of investigating #54987 — they fix two independent bugs that surface together when toggling the search bar.
Test plan
cargo clippy -p markdown_preview -- --deny warnings.Cmd-Fin the markdown preview no longer clips bottom content past the pane edge.Escrestores the preview to full available height.Release Notes: