Skip to content

repl: Refresh Python kernelspecs on buffer language change#54709

Merged
MrSubidubi merged 4 commits into
zed-industries:mainfrom
MostlyKIGuess:fix/repl-ssh-init
May 15, 2026
Merged

repl: Refresh Python kernelspecs on buffer language change#54709
MrSubidubi merged 4 commits into
zed-industries:mainfrom
MostlyKIGuess:fix/repl-ssh-init

Conversation

@MostlyKIGuess

@MostlyKIGuess MostlyKIGuess commented Apr 23, 2026

Copy link
Copy Markdown
Contributor
  • Subscribe to buffer LanguageChanged events so language detection that completes later (e.g. in remote projects) triggers a kernelspec refresh and ensures the REPL UI is populated.

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Closes #54388

Release Notes:

  • Python REPL UI stays responsive on remote connection

@MostlyKIGuess
repl: Refresh Python kernelspecs on buffer language change
75e8d59 
- Subscribe to buffer LanguageChanged events so language detection that
  completes later (e.g. in remote projects) triggers a kernelspec
  refresh
  and ensures the REPL UI is populated.
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Apr 23, 2026
@zed-community-bot zed-community-bot Bot added the guild Pull requests by someone in Zed Guild. NOTE: the label application is automated via github actions label Apr 23, 2026
MrSubidubi
MrSubidubi requested changes May 6, 2026
View reviewed changes

@MrSubidubi MrSubidubi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this is a sensible fix, but I'd love for us to add a test for this - can we perhaps have one where we change the language of a buffer during the test to ensure this is invoked properly?

@MostlyKIGuess

MostlyKIGuess commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

Thanks! I think this is a sensible fix, but I'd love for us to add a test for this - can we perhaps have one where we change the language of a buffer during the test to ensure this is invoked properly?

Done!

MrSubidubi
MrSubidubi approved these changes May 15, 2026
View reviewed changes

@MrSubidubi MrSubidubi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@MrSubidubi MrSubidubi enabled auto-merge May 15, 2026 11:58
@MrSubidubi MrSubidubi added this pull request to the merge queue May 15, 2026
Merged via the queue into zed-industries:main with commit d88afd0 May 15, 2026
32 checks passed
This was referenced May 27, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrSubidubi MrSubidubi MrSubidubi approved these changes

Assignees

@MrSubidubi MrSubidubi

Labels

cla-signed The user has signed the Contributor License Agreement guild Pull requests by someone in Zed Guild. NOTE: the label application is automated via github actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SSH remote Python REPL UI stays hidden until a local window initializes global Jupyter kernels

3 participants

@MostlyKIGuess @MrSubidubi @zelenenka