Skip to content

eslint: Fix ESLint server startup failure on stale cached server install#52883

Merged
smitbarmase merged 1 commit intomainfrom
verify-eslint-cached-server-exists-before-reuse
Apr 1, 2026
Merged

eslint: Fix ESLint server startup failure on stale cached server install#52883
smitbarmase merged 1 commit intomainfrom
verify-eslint-cached-server-exists-before-reuse

Conversation

@smitbarmase
Copy link
Copy Markdown
Member

Closes #19709 (comment)
Closes #24194 (comment)

This PR fixes case where if eslint cached install is partial or stale, Zed can try to launch a missing eslintServer.js and the server crashes with MODULE_NOT_FOUND.

Error: Cannot find module '/Users/.../languages/eslint/vscode-eslint-2.4.4/vscode-eslint/server/out/eslintServer.js'

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • Fixed ESLint server startup failures caused by reusing an incomplete or stale cached server install.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Apr 1, 2026
@zed-community-bot zed-community-bot bot added the staff Pull requests authored by a current member of Zed staff label Apr 1, 2026
@SomeoneToIgnore SomeoneToIgnore self-assigned this Apr 1, 2026
@smitbarmase smitbarmase merged commit ac20488 into main Apr 1, 2026
41 checks passed
@smitbarmase smitbarmase deleted the verify-eslint-cached-server-exists-before-reuse branch April 1, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Language server error: eslint, Error: Cannot find module 'vscode-languageserver/node' ESLint LSP fails to load in Zed

2 participants