Skip to content

editor: Merge additional completion edits into primary undo transaction#52699

Merged
Veykril merged 3 commits intozed-industries:mainfrom
HuaGu-Dragon:completion
Mar 30, 2026
Merged

editor: Merge additional completion edits into primary undo transaction#52699
Veykril merged 3 commits intozed-industries:mainfrom
HuaGu-Dragon:completion

Conversation

@HuaGu-Dragon
Copy link
Copy Markdown
Contributor

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Closes #45986

Release Notes:

  • Fixed postfix snippets now creating 1 undo actions instead of 2.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 30, 2026
@zed-codeowner-coordinator zed-codeowner-coordinator bot requested review from a team, Veykril and cole-miller and removed request for a team March 30, 2026 06:01
Copy link
Copy Markdown
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've wanted this fixed for ages!

@Veykril Veykril enabled auto-merge (squash) March 30, 2026 07:11
auto-merge was automatically disabled March 30, 2026 10:41

Head branch was pushed to by a user without write access

@HuaGu-Dragon
Copy link
Copy Markdown
Contributor Author

@Veykril
Sorry, I accidentally introduced an extra newline when copying the test code, which caused the cargo fmt check to fail. I've fixed it locally and pushed the change. CI should pass now.
Would you mind taking another look?

@Veykril Veykril enabled auto-merge (squash) March 30, 2026 11:02
@Veykril Veykril merged commit 0640e55 into zed-industries:main Mar 30, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Postfix snippets create 2 "undo" actions instead of 1 in Rust

2 participants