Skip to content

Remove PR size notifications#52373

Merged
ConradIrwin merged 2 commits intomainfrom
reduce-github-notifications
Mar 27, 2026
Merged

Remove PR size notifications#52373
ConradIrwin merged 2 commits intomainfrom
reduce-github-notifications

Conversation

@ConradIrwin
Copy link
Copy Markdown
Member

These are noisy, and in general I'd prefer people to focus on the
quality of the resulting system; not the size of the diff. (Which may
require deliberately making changes larger)

Context

How to Review

Self-Review Checklist

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • N/A

These are noisy, and in general I'd prefer people to focus on the
quality of the resulting system; not the size of the diff. (Which may
require deliberately making changes larger)
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 25, 2026
@zed-codeowner-coordinator zed-codeowner-coordinator bot requested a review from a team March 25, 2026 02:58
@zed-community-bot zed-community-bot bot added the staff Pull requests authored by a current member of Zed staff label Mar 25, 2026
@Vastargazing
Copy link
Copy Markdown
Contributor

one thing i noticed — .github/pull_request_template.md still has this line:

(The \large-pr` label is applied automatically.)`

after this PR merges, that won't be true anymore. a contributor opening a large PR might wait for the bot to prompt them about the guided tour section, and it never comes.

probably a one-line fix to remove or update that mention?

@ConradIrwin
Copy link
Copy Markdown
Member Author

Thanks for spotting that @Vastargazing!

@ConradIrwin ConradIrwin enabled auto-merge (squash) March 27, 2026 03:34
@ConradIrwin ConradIrwin merged commit 6bc34ff into main Mar 27, 2026
30 checks passed
@ConradIrwin ConradIrwin deleted the reduce-github-notifications branch March 27, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants