Skip to content

Add hidden model filtering to agent model selectors#52347

Closed
ljt019 wants to merge 6 commits into
zed-industries:mainfrom
ljt019:hide-models
Closed

Add hidden model filtering to agent model selectors#52347
ljt019 wants to merge 6 commits into
zed-industries:mainfrom
ljt019:hide-models

Conversation

@ljt019

@ljt019 ljt019 commented Mar 24, 2026

Copy link
Copy Markdown

Context

This adds support for hiding models from the agent model selectors.

Zed already supports favoriting models, but there is not currently a way to reduce noise in the model list that largely shows old/less frequently used models. This change adds a 'hidden_models' setting for both built-in language models and ACP/custom agent servers, and filters those models out of the corresponding selectors.

This behavior is intentionally simple, this pr does not add any new ui and must be configured within the settings file, I'm open to adding UI for it if you guys want though :)

Self-Review Checklist

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • Added support for hiding models from agent model selectors via hidden_models settings.

@cla-bot

cla-bot Bot commented Mar 24, 2026

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement, and we don't have @ljt019 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@ljt019

ljt019 commented Mar 24, 2026

Copy link
Copy Markdown
Author

@cla-bot check

@cla-bot

cla-bot Bot commented Mar 24, 2026

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement, and we don't have @ljt019 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@cla-bot

cla-bot Bot commented Mar 24, 2026

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

@ljt019

ljt019 commented Mar 24, 2026

Copy link
Copy Markdown
Author

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Mar 24, 2026
@cla-bot

cla-bot Bot commented Mar 24, 2026

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

@SomeoneToIgnore SomeoneToIgnore added the area:ai Related to Agent Panel, Edit Prediction, Copilot, or other AI features label Mar 24, 2026
ljt019 and others added 2 commits April 26, 2026 19:42
…e-models

# Conflicts:
#	crates/agent_ui/src/agent_configuration.rs
#	crates/agent_ui/src/language_model_selector.rs
#	crates/agent_ui/src/model_selector.rs
@benbrandt

Copy link
Copy Markdown
Member

Hey thanks for reaching out but I think this adds some complexity I'd need to think about and the PR is older and we don't have a ton of people asking for this right now, so going to close

@benbrandt benbrandt closed this May 17, 2026
@ljt019

ljt019 commented May 18, 2026

Copy link
Copy Markdown
Author

Hey thanks for reaching out but I think this adds some complexity I'd need to think about and the PR is older and we don't have a ton of people asking for this right now, so going to close

Well let me know, I did my best to keep it up to date so it wasn't stale. I kept it out of adding any ui with the feature so it wouldn't complicate things much, it's almost an exact copy of the favorite code just hides instead, and I'm happy to make any adjustments if you change your mind in the future.

It's really frustrating seeing a huge wall of models I never use, and I know I've seen issues and discussions, albeit not super popular like you said asking for this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ai Related to Agent Panel, Edit Prediction, Copilot, or other AI features cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants