Don't keep stale predictions in if they were discarded#52334
Merged
probably-neb merged 1 commit intomainfrom Mar 24, 2026
Merged
Don't keep stale predictions in if they were discarded#52334probably-neb merged 1 commit intomainfrom
probably-neb merged 1 commit intomainfrom
Conversation
maxbrunsfeld
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We're seeing issues where discarding a prediction (e.g.
editor::Cancelwhile a prediction is being shown) seems to just hide it temporarily. This is becoming a larger issue with #51842 as we now expect people to be dismissing predictions in order to insert literal tabs in certain contexts.The logic changed in this PR is part of the problem, but the model generating the same prediction multiple times is also likely contributing. That will be solved as-needed later.
Self-Review Checklist
Release Notes: