Skip to content

Don't keep stale predictions in if they were discarded#52334

Merged
probably-neb merged 1 commit intomainfrom
dont-preserve-discarded-predictions
Mar 24, 2026
Merged

Don't keep stale predictions in if they were discarded#52334
probably-neb merged 1 commit intomainfrom
dont-preserve-discarded-predictions

Conversation

@probably-neb
Copy link
Copy Markdown
Collaborator

@probably-neb probably-neb commented Mar 24, 2026

Context

We're seeing issues where discarding a prediction (e.g. editor::Cancel while a prediction is being shown) seems to just hide it temporarily. This is becoming a larger issue with #51842 as we now expect people to be dismissing predictions in order to insert literal tabs in certain contexts.
The logic changed in this PR is part of the problem, but the model generating the same prediction multiple times is also likely contributing. That will be solved as-needed later.

Self-Review Checklist

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • Fixed an issue where dismissing an edit prediction would not fully discard it, causing it to re-appear

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 24, 2026
@zed-codeowner-coordinator zed-codeowner-coordinator bot requested review from a team, as-cii and dinocosta and removed request for a team March 24, 2026 15:02
@zed-community-bot zed-community-bot bot added the staff Pull requests authored by a current member of Zed staff label Mar 24, 2026
@probably-neb probably-neb merged commit b5fc09e into main Mar 24, 2026
48 checks passed
@probably-neb probably-neb deleted the dont-preserve-discarded-predictions branch March 24, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants