Always open microphone track on call join#52236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR works around a 1-2 second audio silence that occurs when unmuting for the first time during a call for Bluetooth headphone users with
mute_on_joinenabled. Bluetooth headphones must switch from A2DP (listening-only) to HFP (microphone-enabled) mode when the mic is first activated, which interrupts audio output. Now the microphone track opens on join (still muted at the publication level), moving this switch to when users already expect a connection delay / audio instability. It should be noted that I expect that the OS microphone indicator will now appear on channel join rather than on first unmute, but I feel this is a justified side effect:mute_on_joinalready see the OS-level microphone indicator for the entire call (even after muting) and already experience the Bluetooth profile switch at join time—this change simply bringsmute_on_joinusers in line with that existing behavior.How to Review
Self-Review Checklist
Release Notes:
mute_on_joinis enabled.