Skip to content

Always open microphone track on call join#52236

Merged
kubkon merged 2 commits intomainfrom
fix-bluetooth-audio-silence-on-unmute
Mar 25, 2026
Merged

Always open microphone track on call join#52236
kubkon merged 2 commits intomainfrom
fix-bluetooth-audio-silence-on-unmute

Conversation

@JosephTLyons
Copy link
Copy Markdown
Collaborator

@JosephTLyons JosephTLyons commented Mar 23, 2026

Context

This PR works around a 1-2 second audio silence that occurs when unmuting for the first time during a call for Bluetooth headphone users with mute_on_join enabled. Bluetooth headphones must switch from A2DP (listening-only) to HFP (microphone-enabled) mode when the mic is first activated, which interrupts audio output. Now the microphone track opens on join (still muted at the publication level), moving this switch to when users already expect a connection delay / audio instability. It should be noted that I expect that the OS microphone indicator will now appear on channel join rather than on first unmute, but I feel this is a justified side effect:

  1. This is consistent with other apps—joining a Slack huddle with "Mute my microphone" enabled also shows the indicator immediately on join while muted.
  2. Zed users without mute_on_join already see the OS-level microphone indicator for the entire call (even after muting) and already experience the Bluetooth profile switch at join time—this change simply brings mute_on_join users in line with that existing behavior.

How to Review

Self-Review Checklist

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • Fixed 1-2 seconds of audio silence when unmuting for the first time during a call with Bluetooth headphones when mute_on_join is enabled.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 23, 2026
@zed-codeowner-coordinator zed-codeowner-coordinator bot requested a review from a team March 23, 2026 18:02
@zed-community-bot zed-community-bot bot added the staff Pull requests authored by a current member of Zed staff label Mar 23, 2026
@zed-codeowner-coordinator zed-codeowner-coordinator bot requested review from Veykril and reflectronic and removed request for a team March 23, 2026 18:02
@Veykril Veykril assigned kubkon and unassigned Veykril Mar 23, 2026
Copy link
Copy Markdown
Member

@kubkon kubkon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@kubkon kubkon merged commit 5baec85 into main Mar 25, 2026
38 checks passed
@kubkon kubkon deleted the fix-bluetooth-audio-silence-on-unmute branch March 25, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants