Skip to content

Fix regression preventing new predictions from being previewed in subtle mode (#51887) (cherry-pick to preview)#52224

Merged
zed-zippy[bot] merged 1 commit intov0.229.xfrom
cherry-pick-v0.229.x-8b822f9e
Mar 23, 2026
Merged

Fix regression preventing new predictions from being previewed in subtle mode (#51887) (cherry-pick to preview)#52224
zed-zippy[bot] merged 1 commit intov0.229.xfrom
cherry-pick-v0.229.x-8b822f9e

Conversation

@zed-zippy
Copy link
Copy Markdown
Contributor

@zed-zippy zed-zippy bot commented Mar 23, 2026

Cherry-pick of #51887 to preview


Context

Fixes some issues with #51842
Namely that the tests were scattered and not well organized (this PR
also makes them more thorough), and a regression where holding the
modifiers for the accept prediction keybind would not cause an incoming
prediction to be immediately previewed.

How to Review

Self-Review Checklist

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX
    checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • (Preview v0.229.x only) Fixed a regression where holding the modifiers
    for the accept edit prediction keybind would not immediately preview
    predictions as they arrived

…tle mode (#51887)

## Context

<!-- What does this PR do, and why? How is it expected to impact users?
     Not just what changed, but what motivated it and why this approach.

Link to Linear issue (e.g., ENG-123) or GitHub issue (e.g., Closes #456)
     if one exists — helps with traceability. -->
Fixes some issues with #51842
Namely that the tests were scattered and not well organized (this PR
also makes them more thorough), and a regression where holding the
modifiers for the accept prediction keybind would not cause an incoming
prediction to be immediately previewed.

## How to Review

<!-- Help reviewers focus their attention:
- For small PRs: note what to focus on (e.g., "error handling in
foo.rs")
- For large PRs (>400 LOC): provide a guided tour — numbered list of
files/commits to read in order. (The `large-pr` label is applied
automatically.)
     - See the review process guidelines for comment conventions -->

## Self-Review Checklist

<!-- Check before requesting review: -->
- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- (Preview v0.229.x only) Fixed a regression where holding the modifiers
for the accept edit prediction keybind would not immediately preview
predictions as they arrived
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 23, 2026
@zed-codeowner-coordinator zed-codeowner-coordinator bot requested review from a team, as-cii and dinocosta and removed request for a team March 23, 2026 15:43
@zed-community-bot zed-community-bot bot added the bot Pull requests authored by a bot label Mar 23, 2026
@zed-zippy zed-zippy bot merged commit c847d98 into v0.229.x Mar 23, 2026
41 checks passed
@zed-zippy zed-zippy bot deleted the cherry-pick-v0.229.x-8b822f9e branch March 23, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot Pull requests authored by a bot cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants