Conversation
Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
📏 PR Size: 749 lines changed (size/L)Please note: this PR exceeds the 400 LOC soft limit.
✅ Guided tour detected — thank you! |
yara-blue
reviewed
Mar 20, 2026
yara-blue
reviewed
Mar 20, 2026
yara-blue
reviewed
Mar 20, 2026
| @@ -546,40 +483,6 @@ impl rodio::Source for RodioEffectsAdaptor { | |||
| pub struct Speaker { | |||
Member
There was a problem hiding this comment.
In principle we can take this out as well. It was used to add metadata to replay's, and to prevent recording non-staff users. Now that we have removed the replay system we do not need this info anymore.
Member
There was a problem hiding this comment.
On the other hand it can be nice for future debugging if the live-kit tracks have sensible names. Ok with leaving it in.
yara-blue
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Smit Barmase heysmitbarmase@gmail.com
We've decided to remove rodio backend for audio as we didn't have time to get it to a nice spot. I personally believe we should eventually re-land it (the composable pipelines are quite nice!), but given that we need audio to work, this seems like the best way forward. We won't have to worry about all the ways in which the legacy pipeline interoped with rodio's.
Self-Review Checklist
Release Notes: