Fix switching between helix and vim modes to not require returning to non-modal in between#51706
Merged
dinocosta merged 4 commits intozed-industries:mainfrom Mar 24, 2026
Conversation
Introduce `settings_ui::page_data::write_vim_mode` and `settings_ui::page_data::write_helix_mode` functions which ensure that, when one of these modes is being enabled, if the other is set and also enabled, it disables it. This ensures that, in the Settings UI, toggling either vim mode or helix mode will disable helix mode or vim mode, respectively.
Contributor
Author
|
@dinocosta Thanks! this drives me insane! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51704
Previously it took three inputs of
workspace: toggle vim modeto switch from helix mode back to vim mode and three inputs ofworkspace: toggle helix modeto switch to helix mode from vim mode.Now it takes only one, when the setting is updated, the editor needs to be deactivated and reactivated, this won't cause performance issues because this is not a code path that people hit frequently, if it all. The only reason I hit it so much is contributing to zed and fixing helix mode issues as a vim mode user.
Before:
oldbehavior.mov
After:
Screen.Recording.2026-03-16.at.4.32.42.PM.mov
Before you mark this PR as ready for review, make sure that you have:
Release Notes: